Added libcurl abstractions to libcurl directory #1329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, but please squash all of these down to a single commit, since the changes for the intermediate changes won't be buildable (as they'll be missing from the Xcode project file). If you can do that, I can kick off a test-and-merge step. Thanks! |
|
@alblue , Sure .. |
saiHemak
force-pushed
the
libcurl-classes
branch
from
be3bec3 to
3efe613
Compare
|
@alblue Done ..Please review |
|
@swift-ci please test and merge |
1 similar comment
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am creating this PR based on the comments received for #1216.
@alblue @xwu @pushkarnk This PR has the changes which needed just a movement from one folder to the other.
I will be raising other PR for which basically carves out the common code to Nativeprotocol.
Please review ..